Fix missing type reference on generated attributes for flags #218
+54
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S is enabled causing XML schema type references to not be produced for attributes associated with flags. This change restores the correct behavior by adding a type.isGeneratedType conditional check. Resolves usnistgov/liboscal-java#181.
david-waltermire
force-pushed
the
liboscal-java-issue181-fix-datatype-reference
branch
from
e5337d5 to
cafa864
Compare
aj-stein-nist
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Looks good to me.
I ran the example 0.12.1 cli generated schema command versus a local build with this patch off this branch with example model and schemas in this Gist and I am able to get inline types.
david-waltermire
deleted the
liboscal-java-issue181-fix-datatype-reference
branch
aj-stein-nist
added a commit
to usnistgov/liboscal-java
that referenced
this pull request
Sep 20, 2023
Update to upcoming metaschema-java release 0.12.2 to get updated XML schema generation type signature code from usnistgov/metaschema-java#218. Fixes #181.
aj-stein-nist
added a commit
to usnistgov/liboscal-java
that referenced
this pull request
Sep 20, 2023
Update to upcoming metaschema-java release 0.12.2 to get updated XML schema generation type signature code from usnistgov/metaschema-java#218. Fixes #181.
aj-stein-nist
added a commit
to usnistgov/liboscal-java
that referenced
this pull request
Sep 21, 2023
Update to upcoming metaschema-java release 0.12.2 to get updated XML schema generation type signature code from usnistgov/metaschema-java#218. Fixes #181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Fixed a bug caused when the SchemaGenerationFeature.INLINE_DEFINITIONS is enabled causing XML schema type references to not be produced for attributes associated with flags. This change restores the correct behavior by adding a type.isGeneratedType conditional check. Resolves usnistgov/liboscal-java#181.
This issue is difficult to test for, since it involves testing a specialized schema generation configuration. A new issue has been created to work on this.
All Submissions:
Changes to Core Features: